Wednesday, 2015-01-28

jcrossley3just to be clear, the calling the client's EventSource.close *does* close the socket, but the :on-close never gets called, ostensibly because the server never sends to find out the channel is gone.00:03
jcrossley3so this may be a dump test case, or it may simply be impossible to invoke :on-close on the server when the client cleanly shuts down00:04
jcrossley3dumb*00:06
*** audaxion <audaxion!~siksia@unaffiliated/siksia> has quit IRC (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)01:28
*** statonjr <statonjr!~statonjr@cpe-098-024-171-126.carolina.res.rr.com> has quit IRC (Quit: statonjr)01:41
*** jcrossley3 is now known as jcrossley3-away02:06
*** DomKM <DomKM!uid23709@gateway/web/irccloud.com/x-cnqpfhnalceqmofk> has quit IRC (Quit: Connection closed for inactivity)02:33
jcrossley3-awaytcrawley-away: it would seem to me that if the OS can recognize the state of the socket has been changed (closed, by the client), then undertow can, too. are you sure there's no handler you can register that gets socket change notifications?02:40
*** tcrawley-away is now known as tcrawley03:00
tcrawleyjcrossley3-away: http://stackoverflow.com/questions/151590/how-to-detect-a-remote-side-socket-close03:10
jbossbotTitle: java - How to detect a remote side socket close? - Stack Overflow03:10
tcrawleyI wonder if the race condition is from send! being async, so close gets called before the :close message is sent?03:10
tcrawleysse/send! should probably take a on-complete callback, and that would be the place to perform the close03:11
*** tcrawley is now known as tcrawley-away03:14
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant03:29
jcrossley3-awayi'm not sure that would eliminate the race condition04:06
jcrossley3-awayas i don't think on-complete can know exactly when the client responds to the event04:07
jcrossley3-awayit makes me wonder whether on-close makes any sense at all for unidirectional streams04:08
jcrossley3-awayon-complete, if needed, should suffice04:09
*** audaxion <audaxion!~siksia@unaffiliated/siksia> has joined #immutant04:43
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 246 seconds)05:13
*** JulioBarros <JulioBarros!~juliobarr@c-50-186-32-133.hsd1.or.comcast.net> has quit IRC ()05:30
*** conan <conan!~conan@mdproctor.plus.com> has quit IRC (Read error: No route to host)06:09
*** conan <conan!~conan@mdproctor.plus.com> has joined #immutant06:10
*** galderz <galderz!~galder@redhat/jboss/galderz> has joined #immutant07:05
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has joined #immutant07:58
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has quit IRC (Remote host closed the connection)08:36
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has joined #immutant08:37
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has quit IRC (Ping timeout: 244 seconds)08:41
*** dm3 <dm3!~dm3@pub158181119172.dh-hfc.datazug.ch> has joined #immutant08:54
*** marianoguerra <marianoguerra!~marianogu@emesene/grandpa/marianoguerra> has quit IRC (Quit: leaving)09:11
*** marianoguerra <marianoguerra!~marianogu@emesene/grandpa/marianoguerra> has joined #immutant09:12
*** galderz <galderz!~galder@redhat/jboss/galderz> has quit IRC (Quit: This computer has gone to sleep)09:42
*** DomKM <DomKM!uid23709@gateway/web/irccloud.com/x-qjyscrkoreibkzlc> has joined #immutant09:45
*** qwerty_nor <qwerty_nor!~Thunderbi@5.248.107.224> has joined #immutant09:46
*** galderz <galderz!~galder@redhat/jboss/galderz> has joined #immutant09:59
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant11:20
*** marianoguerra <marianoguerra!~marianogu@emesene/grandpa/marianoguerra> has quit IRC (Quit: leaving)11:27
*** marianoguerra <marianoguerra!~marianogu@emesene/grandpa/marianoguerra> has joined #immutant11:30
*** statonjr <statonjr!~statonjr@cpe-098-024-171-126.carolina.res.rr.com> has joined #immutant11:41
*** galderz <galderz!~galder@redhat/jboss/galderz> has quit IRC (Quit: Leaving)12:01
*** statonjr <statonjr!~statonjr@cpe-098-024-171-126.carolina.res.rr.com> has quit IRC (Quit: statonjr)12:06
*** galderz <galderz!~galder@redhat/jboss/galderz> has joined #immutant12:24
*** jcrossley3-away is now known as jcrossley312:45
*** statonjr <statonjr!~statonjr@209.34.239.254> has joined #immutant12:57
*** bbrowning_away is now known as bbrowning12:59
*** cap10morgan <cap10morgan!~cap10morg@2601:1:b200:1c6:a:8d30:ceb8:1e59> has joined #immutant13:19
*** cap10morgan <cap10morgan!~cap10morg@2601:1:b200:1c6:a:8d30:ceb8:1e59> has quit IRC (Client Quit)13:22
*** cap10morgan <cap10morgan!~cap10morg@2601:1:b200:1c6:54dd:1cb6:f0fb:460e> has joined #immutant13:29
*** statonjr <statonjr!~statonjr@209.34.239.254> has quit IRC (Quit: statonjr)13:35
*** cap10morgan <cap10morgan!~cap10morg@2601:1:b200:1c6:54dd:1cb6:f0fb:460e> has quit IRC (Quit: Computer has gone to sleep.)13:41
jbossbotgit [immutant] push thedeuce 3b04a20.. Jim Crossley Some light renaming, docs etc [IMMUTANT-439]13:42
jbossbotgit [immutant] push thedeuce b54d482.. Jim Crossley Reorganize SSE test a bit13:42
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/compare/97f6d4f...b54d48213:42
jbossbotjira [IMMUTANT-439] Provide SSE support in web [Open (Unresolved) Feature Request, Major, Jim Crossley] https://issues.jboss.org/browse/IMMUTANT-43913:42
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 255 seconds)13:49
*** statonjr <statonjr!~statonjr@107.14.48.192> has joined #immutant13:50
projectodd-ciProject immutant2-incremental build #445: SUCCESS in 20 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/445/14:04
projectodd-ci* Jim Crossley: Some light renaming, docs etc [IMMUTANT-439]14:04
jbossbotjira [IMMUTANT-439] Provide SSE support in web [Open (Unresolved) Feature Request, Major, Jim Crossley] https://issues.jboss.org/browse/IMMUTANT-43914:04
projectodd-ci* Jim Crossley: Reorganize SSE test a bit14:04
*** tcrawley-away is now known as tcrawley14:26
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Quit: ERC Version 5.3 (IRC client for Emacs))14:27
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant14:27
tcrawleyjcrossley3: closing in an on-complete handler prevents the race condition for me.14:44
tcrawleyand I suspect the browser calls all the listeners before reading from the socket again (which is where it discovers it's closed)14:45
tcrawleysince it's a single-threaded event loop14:45
tcrawleywe should probably have the same options to sse/send! as async/send!, and you could just do (sse/send! data :close? true)14:46
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant14:49
jcrossley3tcrawley: that'll just cause the client to reconnect14:49
tcrawleywhy? ':close? true' closes in an :on-complete handler14:50
jcrossley3i'm no SSE expert, but since EventSource objects attempt to reconnect by default whenever they lose a connection, i would expect the server side to not close very often14:51
jcrossley3i.e. leave it up to the client, the consumer of the events14:52
jcrossley3how do you feel about ix-naying on-close for uni streams?14:52
*** cap10morgan <cap10morgan!~cap10morg@75-148-43-81-Colorado.hfc.comcastbusiness.net> has joined #immutant14:54
tcrawleywe need to keep on-close, so you know when the browser goes away, and for sse, you would want to know the same thing. but in normal sse usage (where the client is responsible for closing, and you send a message telling it to do so), then on-close is only useful for detecting a gone client14:54
jcrossley3but you can only tell me that when i attempt to send, right?14:55
tcrawleycorrect14:55
jcrossley3then why do we need on-complete *and* on-close?14:55
jcrossley3on-close is confusing in a uni context14:56
jcrossley3speaking as one who got confused14:56
tcrawleyclient close isn't the only way the stream gets closed. if it gets closed normally from the server side, you may want to act on that as well, which means you have two code paths for dealing with a close instead of one14:59
tcrawleyif you mark your last send! with :close? true, and have an on-close handler, things will just work14:59
tcrawleyif the client goes away in the middle of streaming events, on-close is called. if you send a close event as your last event, the client closes cleanly, does not reconnect, and on-close gets called15:00
jcrossley3i don't think you're hearing me :)15:15
*** cap10morgan_ <cap10morgan_!~cap10morg@75-148-43-81-Colorado.hfc.comcastbusiness.net> has joined #immutant15:16
*** cap10morgan <cap10morgan!~cap10morg@75-148-43-81-Colorado.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 252 seconds)15:20
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Ping timeout: 264 seconds)15:42
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant15:45
*** mgoldmann is now known as mgoldmann|away15:50
*** tmbrooke <tmbrooke!~tmbrooke@cpe-174-110-157-255.carolina.res.rr.com> has joined #immutant16:00
*** tmbrooke <tmbrooke!~tmbrooke@cpe-174-110-157-255.carolina.res.rr.com> has left #immutant16:01
*** audaxion <audaxion!~siksia@unaffiliated/siksia> has quit IRC (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)16:03
*** jcrossle_ <jcrossle_!~user@71-90-202-246.dhcp.stls.mo.charter.com> has joined #immutant16:47
*** jcrossle_ <jcrossle_!~user@71-90-202-246.dhcp.stls.mo.charter.com> has quit IRC (Remote host closed the connection)16:48
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Ping timeout: 264 seconds)16:50
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant16:55
*** lanceball is now known as lance|afk17:15
*** audaxion <audaxion!~siksia@unaffiliated/siksia> has joined #immutant17:25
*** dm3_ <dm3_!~dm3@pub158181119172.dh-hfc.datazug.ch> has joined #immutant17:31
*** dm3 <dm3!~dm3@pub158181119172.dh-hfc.datazug.ch> has quit IRC (Ping timeout: 265 seconds)17:35
*** dm3_ <dm3_!~dm3@pub158181119172.dh-hfc.datazug.ch> has quit IRC (Ping timeout: 276 seconds)17:37
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has joined #immutant17:47
*** cap10morgan__ <cap10morgan__!~cap10morg@75-148-43-81-Colorado.hfc.comcastbusiness.net> has joined #immutant18:06
*** cap10morgan_ <cap10morgan_!~cap10morg@75-148-43-81-Colorado.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 255 seconds)18:10
*** statonjr <statonjr!~statonjr@107.14.48.192> has quit IRC (Ping timeout: 265 seconds)18:14
*** statonjr <statonjr!~statonjr@209.34.239.254> has joined #immutant18:19
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has joined #immutant18:20
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has quit IRC (Remote host closed the connection)18:22
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has joined #immutant18:22
jcrossley3so this blows: https://gist.github.com/03fa3466319fcac2273818:25
jcrossley3some wf/glassfish incompatibility maybe?18:25
*** galderz <galderz!~galder@redhat/jboss/galderz> has quit IRC (Quit: This computer has gone to sleep)18:32
tcrawleyweird18:44
*** lance|afk is now known as lanceball18:52
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 264 seconds)18:52
jbossbotgit [immutant] push thedeuce 9fd0f09.. Jim Crossley Refactor sse fns for running in integs...18:53
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/commit/9fd0f091f18:53
projectodd-ciProject immutant2-incremental build #446: FAILURE in 6 min 59 sec: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/446/19:01
projectodd-ciJim Crossley: Refactor sse fns for running in integs19:01
*** JulioBarros <JulioBarros!~juliobarr@c-50-186-32-133.hsd1.or.comcast.net> has joined #immutant19:02
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)19:17
projectodd-ciYippie, build fixed!19:30
projectodd-ciProject immutant2-incremental build #447: FIXED in 20 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/447/19:30
*** statonjr <statonjr!~statonjr@209.34.239.254> has quit IRC (Quit: statonjr)19:32
*** jcrossley3 is now known as jcrossley3-away19:33
*** lanceball is now known as lance|afk19:48
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has joined #immutant19:49
*** qwerty_nor <qwerty_nor!~Thunderbi@5.248.107.224> has quit IRC (Ping timeout: 272 seconds)19:50
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has quit IRC (Remote host closed the connection)20:40
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has joined #immutant20:40
*** dm3 <dm3!~dm3@pub158181107115.dh-hfc.datazug.ch> has quit IRC (Ping timeout: 245 seconds)20:44
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant21:11
tcrawleyjcrossley3-away: did you know that (web/run #'some-handler) fails?21:16
tcrawleywe don't support a var to run21:16
tcrawleyfixing21:16
jcrossley3-awaytcrawley: i *did* experience that!21:16
jcrossley3-awaythought it was something i was doing wrong so ignored it21:16
jcrossley3-awaywhen did that break?21:16
jcrossley3-awayi guess when as-channel was introduced?21:17
tcrawleyI'm not sure when it broke21:17
tcrawleyas-channel changes never touched run though21:17
tcrawleyoh, wait21:17
tcrawleythey did21:17
jcrossley3-awaythe mount maybe?21:17
*** jcrossley3-away is now known as jcrossley321:18
*** tmbrooke <tmbrooke!~tmbrooke@cpe-069-132-201-026.carolina.res.rr.com> has joined #immutant21:18
tcrawleythis is the only change: https://github.com/immutant/immutant/commit/e828d840f6edf07b94fcac9edb90f11e3136a476#diff-f0ede966a7c2700d2a49acf05d75332eL5721:19
jbossbotgit [immutant] e828d84.. Toby Crawley Initial async channel support [IMMUTANT-521]...21:19
jbossbotjira [IMMUTANT-521] Add API for async channels [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/IMMUTANT-52121:19
tcrawleyand the issue is (fn? handler) is false if handler is a var21:20
tcrawleyah, it was here: https://github.com/immutant/immutant/commit/164bffe2c58d5536cdde545d315bbba5dff5c775#diff-f0ede966a7c2700d2a49acf05d75332eL4221:22
jbossbotgit [immutant] 164bffe.. Jim Crossley Major changes to the immutant.web library...21:22
tcrawleywe used to check if handler was a Servlet, then an HttpHandler, then fell through to handle anything else (which caught fn and var)21:23
jcrossley3huh21:24
jcrossley3so that's in the beta?21:24
tcrawleyyeah21:24
jcrossley3how do we not have a test for that?21:25
tcrawleyI'm adding a test for it now21:25
jcrossley3we suck21:25
tcrawleytotes21:25
jbossbotgit [immutant] push thedeuce de4024d.. Toby Crawley Allow immutant.web/run to take a Var [IMMUTANT-524]21:33
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/commit/de4024d8021:33
jbossbotjira [IMMUTANT-524] immutant.web/run no longer accepts a Var as the handler [Open (Unresolved) Bug, Major, Unassigned] https://issues.jboss.org/browse/IMMUTANT-52421:33
*** tmbrooke <tmbrooke!~tmbrooke@cpe-069-132-201-026.carolina.res.rr.com> has quit IRC (Quit: tmbrooke)21:35
jcrossley3good you made a jira21:35
*** tmbrooke <tmbrooke!~tmbrooke@cpe-069-132-201-026.carolina.res.rr.com> has joined #immutant21:35
projectodd-ciProject immutant2-incremental build #448: SUCCESS in 30 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/448/22:10
projectodd-ciToby Crawley: Allow immutant.web/run to take a Var [IMMUTANT-524]22:10
jbossbotjira [IMMUTANT-524] immutant.web/run no longer accepts a Var as the handler [Open (Unresolved) Bug, Major, Unassigned] https://issues.jboss.org/browse/IMMUTANT-52422:10
*** bbrowning is now known as bbrowning_away22:11
*** marianoguerra <marianoguerra!~marianogu@emesene/grandpa/marianoguerra> has quit IRC (Ping timeout: 272 seconds)22:19
*** tmbrooke <tmbrooke!~tmbrooke@cpe-069-132-201-026.carolina.res.rr.com> has quit IRC (Quit: tmbrooke)22:21
*** irsol <irsol!~irsol@unaffiliated/contempt> has quit IRC (Ping timeout: 276 seconds)22:23
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant22:31
*** tmbrooke <tmbrooke!~tmbrooke@cpe-069-132-201-026.carolina.res.rr.com> has joined #immutant22:31
*** irsol <irsol!~irsol@unaffiliated/contempt> has quit IRC (Ping timeout: 265 seconds)22:37
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant22:38
*** tmbrooke <tmbrooke!~tmbrooke@cpe-069-132-201-026.carolina.res.rr.com> has quit IRC (Quit: tmbrooke)22:41
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 264 seconds)22:55
*** cap10morgan__ <cap10morgan__!~cap10morg@75-148-43-81-Colorado.hfc.comcastbusiness.net> has quit IRC (Quit: Computer has gone to sleep.)23:00
tcrawleyjcrossley3: I'm about ready to submit the PR to sente. I'm just having an issue with it in-container. would you be willing to help me debug that in the AM?23:02
*** irsol <irsol!~irsol@unaffiliated/contempt> has quit IRC (Ping timeout: 272 seconds)23:05
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant23:07
*** tcrawley is now known as tcrawley-away23:08
*** tmbrooke <tmbrooke!~tmbrooke@cpe-174-110-157-255.carolina.res.rr.com> has joined #immutant23:13
*** irsol <irsol!~irsol@unaffiliated/contempt> has quit IRC (Ping timeout: 255 seconds)23:15
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant23:17
*** tmbrooke <tmbrooke!~tmbrooke@cpe-174-110-157-255.carolina.res.rr.com> has left #immutant23:33

Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!