Monday, 2015-02-09

*** jcrossle_ <jcrossle_!~user@71-90-202-246.dhcp.stls.mo.charter.com> has joined #immutant00:06
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Ping timeout: 264 seconds)00:08
*** jcrossle_ is now known as jcrossley300:19
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant00:48
*** DomKM <DomKM!uid23709@gateway/web/irccloud.com/x-bazcoirptgpgkbco> has quit IRC (Ping timeout: 250 seconds)01:40
*** Guest6263 <Guest6263!sid28312@gateway/web/irccloud.com/x-uzzowoquhkgfgpst> has quit IRC (Ping timeout: 250 seconds)01:42
*** Guest62292 <Guest62292!sid16761@gateway/web/irccloud.com/x-qqnicowwjclshqfa> has quit IRC (Ping timeout: 265 seconds)01:42
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 252 seconds)01:45
*** Guest62292 <Guest62292!sid16761@gateway/web/irccloud.com/x-vwrfqokumfxpcxaa> has joined #immutant01:51
*** DomKM <DomKM!uid23709@gateway/web/irccloud.com/x-eozksjztumkpjxpq> has joined #immutant01:52
*** Guest6263 <Guest6263!sid28312@gateway/web/irccloud.com/x-wzpdnkejdbuhshls> has joined #immutant01:54
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant02:45
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 265 seconds)03:36
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant03:43
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 256 seconds)04:27
jbossbotgit [immutant] push thedeuce 97993db.. Jim Crossley Lose the WS handshake now that we expose the upgrade request [IMMUTANT-521]04:41
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/commit/97993dbe904:41
jbossbotjira [IMMUTANT-521] Add API for async channels [Open (Unresolved) Feature Request, Major, Toby Crawley] https://issues.jboss.org/browse/IMMUTANT-52104:41
projectodd-ciProject immutant2-incremental build #456: SUCCESS in 23 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/456/05:06
projectodd-ciJim Crossley: Lose the WS handshake now that we expose the upgrade request [IMMUTANT-521]05:06
jbossbotjira [IMMUTANT-521] Add API for async channels [Open (Unresolved) Feature Request, Major, Toby Crawley] https://issues.jboss.org/browse/IMMUTANT-52105:06
*** jcrossley3 <jcrossley3!~user@71-90-202-246.dhcp.stls.mo.charter.com> has quit IRC (Ping timeout: 250 seconds)06:42
*** mgoldmann|away is now known as mgoldmann07:34
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has joined #immutant08:02
*** conan <conan!~conan@mdproctor.plus.com> has quit IRC (Read error: Connection reset by peer)08:10
*** conan <conan!~conan@mdproctor.plus.com> has joined #immutant08:12
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has quit IRC (Remote host closed the connection)09:04
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has joined #immutant09:05
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has quit IRC (Ping timeout: 250 seconds)09:09
*** jaen <jaen!~jaen@ip169.copit.pl> has joined #immutant09:48
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant10:24
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has joined #immutant10:42
*** dustinm <dustinm!~dustinm@105.ip-167-114-152.net> has quit IRC (Ping timeout: 245 seconds)11:01
*** dustinm <dustinm!~dustinm@105.ip-167-114-152.net> has joined #immutant11:04
*** qwerty_nor <qwerty_nor!~Thunderbi@5.248.107.224> has joined #immutant11:13
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant12:47
*** tcrawley-away is now known as tcrawley12:49
*** bbrowning_away is now known as bbrowning13:27
*** jcrossle_ <jcrossle_!~user@71-90-202-246.dhcp.stls.mo.charter.com> has joined #immutant13:39
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Read error: Connection reset by peer)13:40
*** jcrossle_ is now known as jcrossley313:44
jcrossley3tcrawley: mind if i run a thought by you?13:58
jcrossley3i was thinking we could eliminate the code/reason args to :on-close (to remove any expectations of non-nil values for streams) by changing open? to closed? in the Channel protocol. a "truthy" return value could be a map containing code/reason.14:01
jcrossley3also interested in your thoughts on my handshake removal14:02
jcrossley3i stopped short of deleting unused code in wboss, e.g. setHandshake, but we prolly should14:03
*** lance|afk is now known as lanceball14:10
*** bobmcw_ is now known as bobmcw14:16
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has joined #immutant14:16
tcrawleyjcrossley3: on-close would then call closed? to see why? If we go that route, I think I'd prefer calling it close-reason instead of closed?14:17
tcrawleythe handshake removal looks good, I think there is some more dead code in immutant that can be removed14:17
tcrawleybut maybe we should replace the handshake fn in the channel protocol with a fn to access the request14:18
jcrossley3i wasn't sure how that would work since some of those delayed functions access the exchange14:20
jcrossley3and the servlet request in-container14:21
tcrawleyI guess we'll find out :)14:21
tcrawleyif it doesn't work, we can force all the delays in the request map when we store it off14:21
jcrossley3then what's the point of the delays? :)14:22
jcrossley3if we think it will work, i would prefer to pass it to on-open than introduce another protocol fn14:22
tcrawleywell, for regular ring requests, they don't get forced14:22
tcrawleypassing to on-open works for me14:22
jcrossley3ah, pb14:22
jcrossley3i'm still doc'ing if any of that ^ strikes your fancy14:23
tcrawleyif we pass to on-open, it will break sente 1.4.0.alpha114:23
tcrawleybut that's ok14:23
tcrawleypete's pretty responsive, and would probably cut another alpha for us14:23
tcrawleyesp. if we have beta2 out14:24
jcrossley3yeah14:24
tcrawleyI'll take a look at passing the response14:24
tcrawleyrequest*14:24
jcrossley3coolio14:24
jcrossley3that'll make wrap-websocket more useful, too14:24
tcrawleytotes14:24
*** cap10morgan <cap10morgan!~cap10morg@2601:1:b200:1c6:752b:4fbc:7dea:82f9> has joined #immutant14:56
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has joined #immutant14:57
tcrawleyjcrossley3: I think I want a request proto fn, because (as-channel request :on-open [ch request] ...)) feels weird15:11
tcrawleyI don't want to force users of as-channel to take a request they don't ever need15:12
tcrawleyand they have to store it off anyway if they want to check something in it in on-close, on-message15:12
jcrossley3i agree it looks weird inside a handler taking a request that then calls as-channel with an on-open that potentially hides it15:13
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)15:13
jcrossley3i'm not crazy about the name 'request' though15:14
jcrossley3upgrade?15:14
tcrawleyupgrade-request ?15:14
tcrawleyhmm, upgrade doesn't make sense for streams15:14
jcrossley3i was just about to ask that?15:14
tcrawleyoriginating-request15:14
jcrossley3better15:14
jcrossley3wfm15:15
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has joined #immutant15:35
*** jaen <jaen!~jaen@ip169.copit.pl> has quit IRC (Ping timeout: 255 seconds)15:56
*** jcrossley3 <jcrossley3!~user@71-90-202-246.dhcp.stls.mo.charter.com> has quit IRC (Quit: ERC Version 5.3 (IRC client for Emacs))16:05
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant16:05
*** conan <conan!~conan@mdproctor.plus.com> has quit IRC (Quit: Computer has gone to sleep.)16:20
*** conan <conan!~conan@mdproctor.plus.com> has joined #immutant16:24
jcrossley3tcrawley: any interest in adding an immutant.web.websocket/as-channel that composes immutant.web.async/as-channel to simplify the docstring of each?16:29
tcrawleywhat would ws as-channel compose?16:30
jcrossley3just async/as-channel, but the valid options and docs would differ. could also call it something other than as-channel, e.g. create16:32
tcrawleyit seems like that would be more confusing. I had considered something like (defn as-websocket [req ...] (if (:websocket? req) (as-channel ...) {:status 404}))16:33
jcrossley3or just a pre-condition16:34
tcrawleya pre-condition would throw, is that what we want there?16:34
jcrossley3if you're calling as-websocket and it's not a ws upgrade, i'd consider that an exception16:35
tcrawleyif you expose /ws, and someone hits it with a regular http request, is that you calling it, or the user?16:36
tcrawleyyou can't stop the user from calling it, and you should probably give them a 404 instead of an error page16:37
jcrossley3i don't feel strongly about it. i like the symmetry with sse, and the doc for as-channel seems a little awkward. but if you don't think it's obviously better, i'm good16:37
tcrawleyI agree that the doc for as-channel is a bit awkward, but it's designed to be able to build something that uses ws and/or streams. splitting it makes that a little more difficult16:38
jcrossley3pb16:38
*** GitHub58 <GitHub58!~GitHub58@192.30.252.45> has joined #immutant16:53
GitHub58[wunderboss] tobias pushed 1 new commit to master: http://git.io/bxV116:53
GitHub58wunderboss/master b650790 Toby Crawley: Allow Storing originating request with channel; drop handshake storage.16:53
*** GitHub58 <GitHub58!~GitHub58@192.30.252.45> has left #immutant16:53
jbossbotTitle: Allow Storing originating request with channel; drop handshake storage. · b650790 · projectodd/wunderboss · GitHub16:53
projectodd-ciProject wunderboss-incremental build #193: SUCCESS in 11 min: https://projectodd.ci.cloudbees.com/job/wunderboss-incremental/193/17:05
projectodd-ciToby Crawley: Allow Storing originating request with channel; drop handshake storage.17:05
jbossbotgit [immutant] push thedeuce 58c8de5.. Toby Crawley Make the request available via the channel.17:16
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/commit/58c8de53517:16
jcrossley3tcrawley: did you happen to notice my TODO in async_test?17:23
jcrossley3i'm not sure what :uri should return there17:23
projectodd-ciProject immutant2-incremental build #457: FAILURE in 13 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/457/17:31
projectodd-ciToby Crawley: Make the request available via the channel.17:31
*** lanceball is now known as lance|afk18:01
tcrawleyjcrossley3: do we include the query-string with the uri for regular ring requests?18:19
jcrossley3tcrawley: nope18:19
tcrawleyis the question "should it be included across the board"? or an async-specific question?18:19
jcrossley3but both objects that we used to call getRequestURI on did18:19
jcrossley3if the answer to the first is yes, then i think ring itself is wrong18:20
tcrawleyI think we should follow ring: https://github.com/ring-clojure/ring/blob/master/SPEC#L5018:20
jcrossley3it's also entirely possible that undertow is wrong18:20
tcrawleysince it's a ring request map18:20
jcrossley3since ut is impl'ing both objects18:21
jcrossley3wfm18:21
tcrawleykk!18:21
* tcrawley is fixing the tests in-container that caused that last failure18:21
jcrossley3kk!18:21
jbossbotgit [immutant] push thedeuce e1a5689.. Toby Crawley Remove more unreadable values from the request map before serializing.18:30
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/commit/e1a5689ee18:30
*** GitHub37 <GitHub37!~GitHub37@192.30.252.34> has joined #immutant18:46
GitHub37[wunderboss] tobias pushed 2 new commits to master: http://git.io/bpKY18:46
GitHub37wunderboss/master 5bbf808 Toby Crawley: [maven-release-plugin] prepare release 0.4.118:46
GitHub37wunderboss/master 1c4d432 Toby Crawley: [maven-release-plugin] prepare for next development iteration18:46
*** GitHub37 <GitHub37!~GitHub37@192.30.252.34> has left #immutant18:46
jbossbotTitle: Comparing b65079079075...1c4d432ea361 · projectodd/wunderboss · GitHub18:46
*** GitHub68 <GitHub68!~GitHub68@192.30.252.41> has joined #immutant18:46
GitHub68[wunderboss] tobias tagged 0.4.1 at f471033: http://git.io/bpKs18:46
*** GitHub68 <GitHub68!~GitHub68@192.30.252.41> has left #immutant18:46
jbossbotTitle: Commits · projectodd/wunderboss · GitHub18:46
projectodd-ciYippie, build fixed!18:53
projectodd-ciProject immutant2-incremental build #458: FIXED in 20 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/458/18:53
projectodd-ciToby Crawley: Remove more unreadable values from the request map before serializing.18:53
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Quit: ERC Version 5.3 (IRC client for Emacs))18:57
projectodd-ciProject wunderboss-incremental build #194: SUCCESS in 10 min: https://projectodd.ci.cloudbees.com/job/wunderboss-incremental/194/18:57
projectodd-ci* Toby Crawley: [maven-release-plugin] prepare release 0.4.118:57
projectodd-ci* Toby Crawley: [maven-release-plugin] prepare for next development iteration18:57
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant18:57
*** mgoldmann is now known as mgoldmann|away19:13
*** lance|afk is now known as lanceball19:23
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)19:26
*** lanceball is now known as lance|afk19:37
*** ianeslick <ianeslick!~ianeslick@c-24-6-209-214.hsd1.ca.comcast.net> has quit IRC (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)19:47
jcrossley3tcrawley: is there any particular reason you use a future in testing.app/chunked-stream?19:48
tcrawleygood question! I think that's a holdover from debugging. let me make sure things work w/o it19:51
jcrossley3they do, which is what prompted my question19:52
tcrawleycool, I'll kill it. thanks for noticing that19:53
jcrossley3mo!19:53
jbossbotgit [immutant] push thedeuce 7219499.. Toby Crawley Remove unneeded future in integ async app.19:54
jbossbotgit [immutant] push thedeuce URL: http://github.com/immutant/immutant/commit/7219499d119:54
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 250 seconds)19:56
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has joined #immutant19:58
jcrossley3tcrawley: are we ok forcing the user to send on strings or byte[]'s?20:00
jcrossley3s/on/only/20:00
jcrossley3i was thinking maybe pass anything to (str) that's not a byte[]20:00
*** ianeslick <ianeslick!~ianeslick@152.179.131.170> has joined #immutant20:01
tcrawleyI thought about encoding the message, but we don't control the other end like we do for messaging/caching, so decided against it. (str) is a good compromise though20:01
tcrawleyI like that20:01
tcrawleywant I should implement it?20:02
jcrossley3yes, thanks!20:02
jcrossley3it's especially nice for sending numbers20:02
tcrawleymp!20:02
jcrossley3in contrived dotimes chunked encoding examples20:03
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Quit: ERC Version 5.3 (IRC client for Emacs))20:11
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant20:11
projectodd-ciProject immutant2-incremental build #459: SUCCESS in 19 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/459/20:15
projectodd-ciToby Crawley: Remove unneeded future in integ async app.20:15
tcrawley:)20:16
*** lance|afk is now known as lanceball20:21
jcrossley3tcrawley: have you tried wss yet, by chance?20:25
tcrawleynope. in theory, it should work, since the ssl portion is handled by utow, but I suppose we should try it20:26
jcrossley3i can do that20:27
jcrossley3tcrawley: did you answer me wrt s/open?/closed?/?20:27
jcrossley3ah, close-reason20:28
tcrawleyyeah, did you respond to that and I missed it? my DSL has been bouncy today20:28
jcrossley3well, i don't cotton to replacing open? with close-reason. they're not exactly congruent. but i suppose we could have both? is that overkill?20:29
tcrawleyI was really saying it seems weird for closed? to return a reason20:30
jcrossley3ah20:30
tcrawleyI thought that was the driver, not because you disliked open?20:30
jcrossley3right20:30
tcrawleyso I was advocating for open? and close-reason, if we don't want to pass the reason to the callback20:31
jcrossley3i prefer passing the reason to the callback. i'm just not crazy about streams' being an empty map. i'd rather not add a fn.20:32
tcrawleyI agree with all that20:33
jcrossley3tcrawley: where do we keep track of sending the headers on the first call of send!?20:37
tcrawleythat's in the channel implementations in wunderboss20:38
jcrossley3ah20:38
tcrawleyactually, undertow handles that for us. we set the headers in ring.clj, but they don't actually get sent until the first write20:39
tcrawleystream or no20:39
jcrossley3gotcha20:39
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has quit IRC (Remote host closed the connection)21:16
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has joined #immutant21:17
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant21:18
*** dm3 <dm3!~dm3@pub082136107166.dh-hfc.datazug.ch> has quit IRC (Ping timeout: 264 seconds)21:21
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzz…)21:30
*** cap10morgan_ <cap10morgan_!~cap10morg@2600:100e:b01a:3c18:bae8:56ff:fe40:58b8> has joined #immutant21:34
*** cap10morgan__ <cap10morgan__!~cap10morg@2601:1:b200:1c6:a151:fa10:7eee:b017> has joined #immutant21:35
*** cap10morgan <cap10morgan!~cap10morg@2601:1:b200:1c6:752b:4fbc:7dea:82f9> has quit IRC (Ping timeout: 245 seconds)21:38
*** cap10morgan_ <cap10morgan_!~cap10morg@2600:100e:b01a:3c18:bae8:56ff:fe40:58b8> has quit IRC (Ping timeout: 245 seconds)21:38
*** fivebat__ <fivebat__!~fivebats@72.52.77.52> has joined #immutant21:56
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 244 seconds)22:06
*** qwerty_nor <qwerty_nor!~Thunderbi@5.248.107.224> has quit IRC (Ping timeout: 245 seconds)22:09
*** bbrowning is now known as bbrowning_away22:15
*** tcrawley is now known as tcrawley-away22:17
*** bostonaholic <bostonaholic!~textual@73.181.28.191> has joined #immutant22:19
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has quit IRC (Quit: ERC Version 5.3 (IRC client for Emacs))22:41
*** jcrossley3 <jcrossley3!~user@redhat/jboss/jc3> has joined #immutant22:41
*** jodaro <jodaro!sid5995@gateway/web/irccloud.com/x-xgqpjglcgzrgcnid> has quit IRC (Ping timeout: 265 seconds)22:54
*** jodaro <jodaro!sid5995@gateway/web/irccloud.com/x-izduyvypfwrplqme> has joined #immutant22:58
*** irsol <irsol!~irsol@unaffiliated/contempt> has quit IRC (Ping timeout: 246 seconds)23:03
*** neektza <neektza!sid57833@gateway/web/irccloud.com/x-kglatiggbefyglrz> has quit IRC (Read error: Connection reset by peer)23:06
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant23:07
*** jodaro <jodaro!sid5995@gateway/web/irccloud.com/x-izduyvypfwrplqme> has quit IRC (Ping timeout: 250 seconds)23:10
*** irsol <irsol!~irsol@unaffiliated/contempt> has quit IRC (Ping timeout: 246 seconds)23:12
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant23:13
*** jodaro <jodaro!sid5995@gateway/web/irccloud.com/x-mnvahdsoyzwtyakb> has joined #immutant23:50

Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!