Friday, 2015-10-16

*** moquist <moquist!~moquist@c-75-67-246-255.hsd1.nh.comcast.net> has joined #immutant00:14
*** projectodd-ci <projectodd-ci!~PircBotx@ec2-54-221-39-150.compute-1.amazonaws.com> has joined #immutant00:14
*** justinmcp <justinmcp!~quassel@198.199.115.124> has joined #immutant00:14
*** irsol <irsol!~irsol@unaffiliated/contempt> has joined #immutant00:14
*** bbrowning_away <bbrowning_away!~bbrowning@redhat/jboss/bbrowning> has joined #immutant00:14
*** egli <egli!~user@alouette.sbs.ch> has joined #immutant00:14
*** dustinm <dustinm!~dustinm@105.ip-167-114-152.net> has joined #immutant00:14
*** xeqi <xeqi!uid81119@gateway/web/irccloud.com/x-sakaeaqufkxacerr> has joined #immutant00:14
*** mgaare <mgaare!~quassel@75.127.15.55> has joined #immutant00:14
*** jcrossle_ <jcrossle_!~user@71-90-202-1.dhcp.stls.mo.charter.com> has joined #immutant00:15
*** hiredman <hiredman!~hiredman@volyovaii.ec2.thelastcitadel.com> has joined #immutant00:15
*** abstractj <abstractj!~abstractj@redhat/jboss/abstractj> has joined #immutant00:15
*** kungi <kungi!kungi@hell.kungi.org> has joined #immutant00:19
*** lanceball <lanceball!~lanceball@redhat/jboss/lanceball> has joined #immutant00:19
*** Guest38454 <Guest38454!sid16761@gateway/web/irccloud.com/x-mbevlfrljczrbred> has joined #immutant00:20
*** mgoldmann|away <mgoldmann|away!~mgoldmann@redhat/jboss/mgoldmann> has joined #immutant00:20
*** conan_ <conan_!~conan@mdproctor.plus.com> has joined #immutant00:21
*** borkdude <borkdude!~borkdude@vps1918.directvps.nl> has joined #immutant00:21
*** pdurbin <pdurbin!~pdurbin@server1.greptilian.com> has joined #immutant00:21
*** michaniskin <michaniskin!sid28312@gateway/web/irccloud.com/x-ljdqrrziwjptzzml> has joined #immutant00:21
*** tcrawley-away <tcrawley-away!~tcrawley@redhat/jboss/tcrawley> has joined #immutant00:21
*** charliekilo <charliekilo!charliekil@2600:3c00::f03c:91ff:fe56:b738> has joined #immutant00:21
*** ubuntu3 <ubuntu3!~ubuntu@ec2-54-210-160-240.compute-1.amazonaws.com> has joined #immutant00:24
*** proddbot <proddbot!~irclj@162.243.1.108> has joined #immutant00:24
*** terjesb <terjesb!~terjesb@ec2-54-247-167-129.eu-west-1.compute.amazonaws.com> has joined #immutant00:25
*** jodaro <jodaro!sid5995@gateway/web/irccloud.com/x-uvkutyhobsvfskot> has joined #immutant00:25
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has joined #immutant00:25
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has quit IRC (Ping timeout: 264 seconds)00:25
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant00:33
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 240 seconds)00:41
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant01:06
*** jbossbot <jbossbot!~JBossBot@redhat/jbossbot> has joined #immutant01:23
*** jcrossle_ is now known as jcrossley3-away01:27
*** tcrawley-away is now known as tcrawley01:33
*** tcrawley is now known as tcrawley-away01:35
*** qbing <qbing!d80f7086@gateway/web/freenode/ip.216.15.112.134> has joined #immutant01:40
*** deadghost <deadghost!~deadghost@122.167.116.29> has joined #immutant01:44
*** SteveJorbs <SteveJorbs!~SteveJorb@c-73-239-4-237.hsd1.wa.comcast.net> has joined #immutant02:25
*** deadghost <deadghost!~deadghost@122.167.116.29> has quit IRC (Ping timeout: 250 seconds)03:15
*** terjesb <terjesb!~terjesb@ec2-54-247-167-129.eu-west-1.compute.amazonaws.com> has quit IRC (Ping timeout: 246 seconds)03:51
*** terjesb <terjesb!~terjesb@ec2-54-247-167-129.eu-west-1.compute.amazonaws.com> has joined #immutant03:53
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has joined #immutant04:18
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has quit IRC (Ping timeout: 272 seconds)04:24
*** SteveJorbs <SteveJorbs!~SteveJorb@c-73-239-4-237.hsd1.wa.comcast.net> has quit IRC ()04:56
*** mgoldmann|away is now known as mgoldmann06:50
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 246 seconds)06:54
*** dm3 <dm3!~dm3@pub082136109248.dh-hfc.datazug.ch> has joined #immutant07:35
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has joined #immutant08:21
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has quit IRC (Ping timeout: 268 seconds)08:27
*** marianoguerra <marianoguerra!~marianogu@emesene/grandpa/marianoguerra> has joined #immutant10:27
*** agarman <agarman!~agarman@169.130.108.20> has joined #immutant11:44
*** deadghost <deadghost!~deadghost@122.167.247.36> has joined #immutant12:17
*** deadghost <deadghost!~deadghost@122.167.247.36> has quit IRC (Ping timeout: 256 seconds)12:31
*** bbrowning_away is now known as bbrowning12:33
*** jcrossley3-away is now known as jcrossley312:40
*** agarman_ <agarman_!~agarman@169.130.108.37> has joined #immutant13:48
*** agarman <agarman!~agarman@169.130.108.20> has quit IRC (Ping timeout: 264 seconds)13:52
*** xcv <xcv!~xcv@37.120.81.58> has joined #immutant14:05
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has joined #immutant14:16
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has quit IRC (Changing host)14:16
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has joined #immutant14:16
*** tdavis <tdavis!~binjured@45.55.33.69> has joined #immutant14:23
tdavisis there a way to use servlet filters with immutant? i've been looking through the code and can't seem to find anything. there might be a :filter-map option but there's no access to registration options if I just provide a Filter instance.14:25
jcrossley3tdavis: maybe? any reason ring middleware wouldn't work for you?14:36
tdavisjcrossley3: my issue is that i have a servlet i need to run with immutant. it would be nice if it were a ring handler instead, but it isn't and i am not familiar enough with the differences to proxy the servlet in a way that makes it act like one.14:40
tdavisi want to apply some middleware to it; the middleware happens to be available as ring middleware and a java filter, of which i'd happily use the former if i could.14:41
jcrossley3do you have a servlet instance that you can pass to immutant.web/run? like pedestal?14:42
jcrossley3or just a class you need to reference in web.xml?14:42
tdavisit's an instance i am passing to immutant.web/run14:42
jcrossley3hmm14:43
jcrossley3i feel like servlet 3.0 has some facility for adding filters at runtime. ring any bells, bbrowning ?14:45
bbrowninghmm14:45
jcrossley3that's what i said!14:45
bbrowningjcrossley3: I think you can only add filters during servlet initialization14:46
bbrowningie http://docs.oracle.com/javaee/7/api/javax/servlet/ServletContext.html#addFilter-java.lang.String-javax.servlet.Filter-14:46
jbossbotTitle: ServletContext (Java(TM) EE 7 Specification APIs)14:47
bbrowningthrows "IllegalStateException - if this ServletContext has already been initialized"14:47
tdavisyep14:47
tdavisthat's what happened when i tried to do it in init()14:47
jcrossley3hmm14:47
tdaviswhich sent me down this path of trying to find an earlier inroad to the servlet configuration, which i have not found14:47
jcrossley3tdavis: so i think if we didn't overwrite this here, you'd be ok, right? https://github.com/immutant/immutant/blob/master/web/src/immutant/web/internal/wunderboss.clj#L6214:54
jcrossley3i'm thinking that's a bug14:54
tdavisyeah, that is problematic, but i'm also unclear on how to configure the filter without access to its registration (probably just me not being familiar enough with servlet)14:56
jcrossley3tdavis: well, it appears to me that you can simply pass an instance of your Filter class to run with the :filter-map option14:59
jcrossley3would that work for you?14:59
jcrossley3i can push an incremental with a potential fix, i think14:59
tdavisyeah, so the filter map is Map<String, Filter> which is cool, and i'm probably just dense, but how do i configure the filter without a FilterRegistration?15:01
jcrossley3what config do you need to do?15:01
tdavisprobably easiest just to show you the failing init() code: https://gist.github.com/tdavis/fe5f6762c7a9292634e115:02
tdavisall of which i made up out of thin air since every document on the internet assumes i have a web.xml15:03
jcrossley3the mapping we would do for you automatically (to match that of the filtered servlet)15:04
jcrossley3the init params are a problem15:04
tdavisdrat, i was hoping i was just dumb :p15:04
jcrossley3can i ask why you have a servlet instead of a ring handler? :)15:04
jcrossley3because i suspect there's plenty of great CORS middleware out there15:05
tdavisthere is15:05
jcrossley3so looking at that code, it seems the init params are there only because you're passing a filter class name rather than an instance, which :filter-map, would require...15:06
jcrossley3so if you can create an instance, it can contain a closure around those init params15:07
jcrossley3would that work?15:07
tdavisi have a servlet because Thrift provides a servlet. i could reimplement it as a ring handler, i suppose, but i was attempting to be lazy... which usually involves hours of research and stuff :p15:07
tdavisyou're saying i could override init(FilterConfig) and just do my own config there?15:08
jcrossley3yes15:08
tdavisi'm fine with that. i didn't know if that would anger the servlet gods or whatever.15:08
jcrossley3lemme push an incremental that preserves :filter-map and you can play with it15:09
tdavisawesome, thanks!15:09
*** dm3 <dm3!~dm3@pub082136109248.dh-hfc.datazug.ch> has quit IRC ()15:10
jcrossley3tdavis: for the time being, we'll ignore the very real possibility that tcrawley-away had a great reason for not exposing that :filter-map option :)15:10
tdavisWebSocketHelpyHelpertonFilter -- o_O15:10
jcrossley3we take great pride in our class names15:11
tdavisjcrossley3: "it's probably fine"15:11
tdavishahaha i can see that15:11
tdavisyou had me at "wunderboss"15:13
jcrossley3:)15:13
*** agarman_ <agarman_!~agarman@169.130.108.37> has quit IRC (Remote host closed the connection)15:24
jcrossley3tdavis: i suspect tcrawley-away was cautious about publishing this option because filter order matters15:40
jcrossley3if you're dealing with multiple filters, you'll want to use a Map that preserves insertion order15:40
tdavisjcrossley3: yeah, that makes sense. will do.15:44
jbossbotgit [immutant] push master b1c7f14.. Jim Crossley Reflect new script options15:48
jbossbotgit [immutant] push master ca6ad28.. Jim Crossley Preserve any passed :filter-map...15:48
jbossbotgit [immutant] push master URL: http://github.com/immutant/immutant/compare/d61f035...ca6ad2815:48
jcrossley3tdavis: it'll take a few minutes for CI to publish that incremental (assuming all integs pass). if you'd rather, you can replicate that small change yourself (easy enough to do at a repl, trickier if deploying to a container)15:49
projectodd-ciProject immutant2-incremental build #657: FAILURE in 1 min 40 sec: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/657/15:50
*** cemerick <cemerick!~cemerick@24-183-148-81.dhcp.oxfr.ma.charter.com> has joined #immutant15:53
projectodd-ciYippee, build fixed!15:56
projectodd-ciProject immutant2-incremental build #658: FIXED in 3 min 57 sec: https://projectodd.ci.cloudbees.com/job/immutant2-incremental/658/15:56
tdavisjcrossley3: if/when it publishes, what's the lein requirement stanza?16:00
jcrossley3tdavis: look at the Incremental Builds section: http://immutant.org/tutorials/installation/16:01
jbossbotTitle: Immutant | Installation16:01
jcrossley3use build number 65816:01
tdavisthanks!16:02
*** deadghost <deadghost!~deadghost@122.167.246.81> has joined #immutant16:02
*** xcv <xcv!~xcv@37.120.81.58> has quit IRC (Ping timeout: 268 seconds)16:03
projectodd-ciProject immutant2-incremental-integs build #164: FAILURE in 7 min 35 sec: https://projectodd.ci.cloudbees.com/job/immutant2-incremental-integs/164/16:04
projectodd-ci* Jim Crossley: Reflect new script options16:04
projectodd-ci* Jim Crossley: Preserve any passed :filter-map16:04
tdavisjcrossley3: hahaha after all that, these jerks made their CORSFilter class final.16:10
jcrossley3bastards16:10
jcrossley3i'm so over OOP, in general :)16:10
tdavisyeah, it's a pita.16:11
jcrossley3tdavis: can you reify a Filter and delegate to a CORSFilter instance?16:11
jcrossley3i guess you'll still need some way to pass init params16:11
jcrossley3ffs16:12
tdavisi'm just gonna see if another implementation doesn't define it as final :p16:12
tdavisor i'll build my own stupid jar. god, i shoulda just reimplemented this servlet in clojure.16:12
jcrossley3heh16:12
jcrossley3tdavis: sorry for the pain. holler if we can help in any way.16:13
tdavisme too... thanks for the fix in any case!16:14
*** lanceball is now known as lance|afk16:14
*** cemerick <cemerick!~cemerick@24-183-148-81.dhcp.oxfr.ma.charter.com> has quit IRC (Ping timeout: 265 seconds)16:14
projectodd-ciProject immutant2-incremental-integs-eap build #208: SUCCESS in 16 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental-integs-eap/208/16:14
projectodd-ci* Jim Crossley: Reflect new script options16:14
projectodd-ci* Jim Crossley: Preserve any passed :filter-map16:14
jcrossley3tdavis: thanks for reporting it... sorta! :)16:14
tdavisheh i was actually going to report that formally but i didn't know if it was a bug or an intended thing.16:16
tdavisyay, cors filter by another company isn't final :p16:16
jcrossley3yay!16:17
tdavisand they even let you configure it outside the confines of servlet lifecycle16:17
jcrossley3tdavis: but you still pass in a filter to run?16:18
jcrossley3if you get that working, holler back, and i'll formally report the bug so it hits the release notes for the next release.16:18
tdavisyeah, i will still be needing :filter-map16:18
tdavisjust don't have to subclass their impl16:19
jcrossley3cool16:19
tdavisshould be up and running shortly, will let you know if it works!16:19
jcrossley3ty!16:19
*** cemerick <cemerick!~cemerick@24-183-148-81.dhcp.oxfr.ma.charter.com> has joined #immutant16:25
projectodd-ciYippee, build fixed!16:34
projectodd-ciProject immutant2-incremental-integs build #165: FIXED in 25 min: https://projectodd.ci.cloudbees.com/job/immutant2-incremental-integs/165/16:34
*** cemerick <cemerick!~cemerick@24-183-148-81.dhcp.oxfr.ma.charter.com> has quit IRC (Ping timeout: 246 seconds)16:45
tdavisjcrossley3: worked!16:52
jcrossley3tdavis: yay! :)17:00
*** agarman <agarman!~agarman@169.130.108.20> has joined #immutant17:01
*** agarman <agarman!~agarman@169.130.108.20> has joined #immutant17:01
*** bbrowning is now known as bbrowning_away17:04
jcrossley3tdavis: i want to discuss it with tcrawley-away, but if you're interested, you can follow IMMUTANT-58617:16
jbossbotjira [IMMUTANT-586] Expose :filter-map option to web/run for deploying Servlet Filters [Open (Unresolved) Feature Request, Major, Unassigned] https://issues.jboss.org/browse/IMMUTANT-58617:16
tdavisjcrossley3: will do!17:19
*** bbrowning_away is now known as bbrowning18:08
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has quit IRC (Read error: Connection reset by peer)18:23
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has joined #immutant18:23
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has quit IRC (Changing host)18:23
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has joined #immutant18:23
*** jcrossley3 is now known as jcrossley3-away18:32
*** mgoldmann is now known as mgoldmann|away18:41
*** lance|afk is now known as lanceball19:02
*** agarman_ <agarman_!~agarman@169.130.108.37> has joined #immutant19:26
*** agarman <agarman!~agarman@169.130.108.20> has quit IRC (Ping timeout: 252 seconds)19:29
*** agarman_ <agarman_!~agarman@169.130.108.37> has quit IRC (Ping timeout: 252 seconds)19:31
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has joined #immutant19:34
*** projectodd-ci <projectodd-ci!~PircBotx@ec2-54-221-39-150.compute-1.amazonaws.com> has quit IRC ()19:49
*** jcrossley3-away is now known as jcrossley319:53
*** jcrossle_ <jcrossle_!~user@71-90-202-1.dhcp.stls.mo.charter.com> has joined #immutant20:07
*** jcrossley3 <jcrossley3!~user@71-90-202-1.dhcp.stls.mo.charter.com> has quit IRC (Ping timeout: 260 seconds)20:08
*** jcrossle_ is now known as jcrossley320:12
*** bbrowning is now known as bbrowning_away20:51
*** projectodd-ci <projectodd-ci!~PircBotx@ec2-54-221-39-150.compute-1.amazonaws.com> has joined #immutant21:09
*** projectodd-ci <projectodd-ci!~PircBotx@ec2-54-221-39-150.compute-1.amazonaws.com> has quit IRC (Client Quit)21:11
*** projectodd-ci <projectodd-ci!~PircBotx@ec2-54-221-39-150.compute-1.amazonaws.com> has joined #immutant21:12
*** jcrossle_ <jcrossle_!~user@71-90-202-1.dhcp.stls.mo.charter.com> has joined #immutant21:19
*** jcrossley3 <jcrossley3!~user@71-90-202-1.dhcp.stls.mo.charter.com> has quit IRC (Ping timeout: 250 seconds)21:23
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has quit IRC (Remote host closed the connection)21:27
*** cemerick <cemerick!~cemerick@c-24-34-140-98.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 250 seconds)21:27
*** xcv <xcv!~xcv@208.167.254.78> has joined #immutant22:18
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has joined #immutant22:27
*** bobmcw <bobmcw!~bobmcw@va-67-233-84-133.dhcp.embarqhsd.net> has quit IRC (Changing host)22:27
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has joined #immutant22:27
*** xcv <xcv!~xcv@208.167.254.78> has quit IRC (Ping timeout: 255 seconds)22:29
*** deadghost <deadghost!~deadghost@122.167.246.81> has quit IRC (Ping timeout: 250 seconds)22:32
*** bobmcw <bobmcw!~bobmcw@redhat/jboss/bobmcw> has quit IRC (Ping timeout: 246 seconds)22:34
*** jcrossle_ is now known as jcrossley3-away23:19

Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!